Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑🏗️ Pigeon broken in Python3.12 onward #66

Open
lstuma opened this issue May 16, 2024 · 1 comment
Open

🚑🏗️ Pigeon broken in Python3.12 onward #66

lstuma opened this issue May 16, 2024 · 1 comment
Labels
🚑 critical Issue needs to be fixed ASAP

Comments

@lstuma
Copy link
Member

lstuma commented May 16, 2024

from Python3.12 onward multithreading is not possible atexit, i.e. Pigeon cannot create new threads and will therefore have to run before python exit.

This will mean we will need to perform some architectural changes in regards to exception handling, exit handling and the way Pigeon is actually run. Currently Pigeon runs automatically if Pigeon.autorun is enabled (default).

Using some hacky techniques Pigeon can still be started by calling Pigeon.run manually. This will probaby be the way to fix this.

@lstuma lstuma added the 🚑 critical Issue needs to be fixed ASAP label May 16, 2024
@lstuma
Copy link
Member Author

lstuma commented May 16, 2024

Proposal: (new way to start Pigeon)

from pigeon import Pigeon

Pigeon(mysettings)
Pigeon.attr = val

...

Pigeon.run()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚑 critical Issue needs to be fixed ASAP
Projects
None yet
Development

No branches or pull requests

1 participant