Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technic_worldgen breaks energy values on dev branch #10

Closed
programmerjake opened this issue Dec 25, 2023 · 6 comments
Closed

technic_worldgen breaks energy values on dev branch #10

programmerjake opened this issue Dec 25, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@programmerjake
Copy link
Contributor

programmerjake commented Dec 25, 2023

Describe the bug
Enabling technic_worldgen from mt-mods causes energy values for most ingot types to not be set.

Expected behavior
iron, gold, tin, etc. ingots have energy values

Game (e.g. Minetest Game)
Minetest Game 5.8.0

Additional context
exchangeclone is at commit d5c153e
technic is at commit mt-mods/technic@f1b9928

reproduction steps:

  • install technic from https://github.com/mt-mods/technic at commit f1b99282e889e9a483c76af95ee3370b6d2b2d04
  • create new world based on minetest game 5.8.0
  • enable exchangeclone dev modpack
  • enable technic_worldgen from technic_mc_compat (editing world.mt might be easiest)
  • run game
  • look up ingots, observe that iron ingot has no energy value.
@programmerjake programmerjake added the bug Something isn't working label Dec 25, 2023
@programmerjake

This comment was marked as resolved.

@programmerjake

This comment was marked as resolved.

@programmerjake programmerjake changed the title Ethereal NG breaks energy values on dev branch technic_worldgen breaks energy values on dev branch Dec 25, 2023
@programmerjake
Copy link
Contributor Author

turns out it's not the mineclone compatibility PR, it's just the latest changes in technic master, available from contentdb at https://content.minetest.net/packages/mt-mods/technic_plus_beta/

@ThePython10110
Copy link
Owner

Interesting. I've been testing with Technic, but not the beta version. I may not be able to test stuff today (with it being Christmas and stuff), but I'll probably check that out tomorrow.

@programmerjake
Copy link
Contributor Author

do note that there's actually several different versions of technic: the one at https://github.com/mt-mods/technic (called Technic Plus/Technic Plus Beta in contentdb, the one I'm having issues with) and the one at https://github.com/minetest-mods/technic (called Technic in contentdb)

ThePython10110 added a commit that referenced this issue Dec 25, 2023
@ThePython10110
Copy link
Owner

ThePython10110 commented Dec 25, 2023

I figured it out... apparently I was handling aliases badly. Basically, if there were recipes where the output was an alias, they would completely overwrite all the recipes of the original item. This means that when Technic is enabled, all the recipes for "default:steel_ingot" are deleted and replaced with the recipes for "technic:wrought_iron_ingot". This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants