Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all the new window target is _blank #108

Open
jcyuan opened this issue Dec 27, 2024 · 0 comments
Open

not all the new window target is _blank #108

jcyuan opened this issue Dec 27, 2024 · 0 comments

Comments

@jcyuan
Copy link

jcyuan commented Dec 27, 2024

const isExternalLink = (anchor as HTMLAnchorElement).target === '_blank';

this line has bug, because i can set my link as <a href="/page" target="_rules" /> so that all the links with this target won't open too many new windows and they will be opened in the same new window, _rules is like a target window name.

now all my '_rules' links will trigger the progress bar to show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant