Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

All the problems I found by a quick look around #26

Closed
TymanWasTaken opened this issue Mar 16, 2021 · 1 comment
Closed

All the problems I found by a quick look around #26

TymanWasTaken opened this issue Mar 16, 2021 · 1 comment

Comments

@TymanWasTaken
Copy link
Contributor

TymanWasTaken commented Mar 16, 2021

  1. You don't define the types of way too many things, mostly function parameters
  2. You have the tsc settings to ignore implicit any and this, not very good practice
  3. Please use consistent capitalization please (ClassName, variableName, FileName.ts)
  4. You have way too many anys (1 is too many) please use unknown if you really really need to
  5. Not really an issue but use https://npmjs.org/package/source-map-support
  6. Some random files use .markdown file extension what
  7. Those files also aren't in caps and thats weird
  8. Missing a workflow
  9. Add dependabot
  10. You appear to disable a bunch of types at the top of files which is not good, use // eslint-disable-next-line if you really really need to, though you shouldn't be disabling those checks anyway
@Tricked-dev Tricked-dev pinned this issue Mar 16, 2021
@Tricked-dev
Copy link
Owner

Fixed most of the issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants