Milestone 4 Feedback

[zwarham]

• Submission (4)
  o 4/4 mechanics
• Improving your app (20)
  o 20/20 mechanics
• Reproducibility – testing (10)
  o 5/5 mechanics
  o 0/5 accuracy
   Tests did not pass in testing.yaml
• Reproducibility – continuous integration and deployment
  o 5/5 mechanics
  o 5/5 accuracy
• Tie it all together and deliver a production ready app (50)
  o 19/20 mechanics
   App title in the browser tab is broken
  o 15/20 accuracy
   The widgets refresh twice upon the first category selection (and intermittently after that)
  o 10/10 visualization
• Reflection
  o 6/6 reasoning

[carolinetang77]

Hello! I see we lost marks for the tests not passing, but according to the github actions workflow, they all passed. Could you clarify why we were docked marks for this?

[zwarham]

Hi, this is the information we review for the workflows

[carolinetang77]

The checks did fail in our initial commit of the testing.yaml, but we fixed the issue in later commits that didn't involve changes to the yml file (we had to update the renv lockfile), and the actions currently run without error, as indicated in the github actions history and on the README.

[zwarham]

In that case please create a conversation on Slack with all your group members, myself and Florencia and ask Florencia for a regrade request and explain your reasoning