Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP address defaults to wlan (might be more useful to default to eth0) #4

Closed
geerlingguy opened this issue Sep 23, 2022 · 1 comment · Fixed by #5
Closed

IP address defaults to wlan (might be more useful to default to eth0) #4

geerlingguy opened this issue Sep 23, 2022 · 1 comment · Fixed by #5

Comments

@geerlingguy
Copy link
Contributor

I just realized after reading through #2 and also seeing @TiVoHomeUser's fork (main...TiVoHomeUser:SKU_RM0004:main), that the default for the IPADDRESS_TYPE is currently set to WLAN0_ADDRESS:

#define IPADDRESS_TYPE WLAN0_ADDRESS

That means my Pis, which are connected via wired network, aren't able to show their IP address.

I think for the rackmount unit, most people will be plugging in wired Ethernet, so it might make sense to default that value to ETH0_ADDRESS like @TiVoHomeUser does.

@geerlingguy geerlingguy changed the title IP address defaults to using wlan address (might be more useful to default to eth0) IP address defaults to wlan (might be more useful to default to eth0) Sep 23, 2022
@geerlingguy
Copy link
Contributor Author

I created a pull request for this change: #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant