Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test giving invalid entries to the log processor as if the gonx library did not work properly #14

Open
Ullaakut opened this issue Apr 6, 2018 · 0 comments
Assignees
Labels
improvement An improvement over some existing feature tests Any task related to testing

Comments

@Ullaakut
Copy link
Owner

Ullaakut commented Apr 6, 2018

In order to properly test the entry parser, we need to make sure that even if a future version of gonx (the parsing library) happens to be sending us invalid data, we handle the errors correctly.

This can be easily done by writing tests that do not use gonx but simply programmatically instantiate gonx.Entry objects and fill them manually with erroneous data.

However, since this is tedious and that I own the version of the library that I use, I know that these tests are most likely not needed for an MVP so I will tag this as a potential future improvement.

@Ullaakut Ullaakut added improvement An improvement over some existing feature tests Any task related to testing labels Apr 6, 2018
@Ullaakut Ullaakut added this to the Future potential improvements milestone Apr 6, 2018
@Ullaakut Ullaakut self-assigned this Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement over some existing feature tests Any task related to testing
Projects
None yet
Development

No branches or pull requests

1 participant