Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPRHelper: Typos(?) "gpdr" #1

Open
m4z opened this issue Apr 29, 2019 · 4 comments
Open

GDPRHelper: Typos(?) "gpdr" #1

m4z opened this issue Apr 29, 2019 · 4 comments

Comments

@m4z
Copy link

m4z commented Apr 29, 2019

I suppose this is by mistake:

> grep -Ri gdpr GDPRHelper1.0.5/ | wc -l
49
> grep -Ri gpdr GDPRHelper1.0.5/ | wc -l
674

It seems to affect every variable name that is written into the DB.

Technically, it's a non-issue, but I got confused when looking for the gdpr* files, until I noticed nearly all of them are called gpdr* ("PD" instead of "DP").

Do you want this to be fixed in a future version (I can write up a PR), or is it on purpose, or you want it to stay this way for compatibility reasons?

@m4z m4z changed the title Typos(?) "gpdr" GDPRHelper: Typos(?) "gpdr" Apr 29, 2019
@VBGAMER45
Copy link
Owner

Yeah I thought about fixing for compatibility reasons as well. I did fix it for the paid version.

@m4z
Copy link
Author

m4z commented May 1, 2019

Ah, is there a general scheme for when paid version fixes and features are merged into the free version? (Like, "whatever fixes were in paid version x.y will be in the free version x.y+1, and new features in paid x.y will be in the free version x.y+3" or so.)

By the way, is there a full list of differences between the free and paid version? The free and paid sites are kind of hard to compare for me, because they're sorted differently, and even for (possibly) more or less identical features, the phrasing is different.
One difference seems to be exporting to more formats (html, xml) than csv. Another seems to be multi-language support. And maybe the "Privacy Policy system" does more than in the free version.

Anyway, I'd be willing to buy the paid version if you then merge the fix into the free version. 😉

@m4z
Copy link
Author

m4z commented May 20, 2019

Would you care to comment? If I offended you in any way, I'm sorry, this was not my intention.

I'd just like to move this forward (both improving the free version, and (knowing what I'm) buying (in) the paid version).

@VBGAMER45
Copy link
Owner

Haven't had time to work on this been on vacation and just really busy at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants