Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villager trades for 1.20.6 servers are invisible on version 1.20.4 and below. #882

Open
4 tasks done
Boxeyy opened this issue Sep 9, 2024 · 14 comments
Open
4 tasks done
Labels

Comments

@Boxeyy
Copy link

Boxeyy commented Sep 9, 2024

'/viaversion dump' Output

https://dump.viaversion.com/3190f75e7ac82e4d9b0cae551394ba65eeef6207a14dde804e069e30447d67ba

Console Error

N/A

Bug Description

When inputting trades in a villager on a 1.20.6+ server while on version 1.20.4 or below the result item appears invisible

Steps to Reproduce

  1. Log on with 1.20.4 or below on 1.20.6
  2. Go to a village
  3. Input the correct items for the trade
  4. Result item is invisible

Expected Behavior

The result item should be visible.

Additional Server Info

Plugins

Bukkit Plugins: (44):

  • ajLeaderboards, AntiPopup, Astro, AxVaults, CataMines, CrazyEnchantments, DecentHolograms, DeluxeCombat, DiscordSRV, Diskuise, ExcellentCrates, FastAsyncWorldEdit, InventoryRollbackPlus, ItemEdit, LibsDisguises, lightEconomy, LiteBans, LPC, LuckPerms, MysteryBoxes, MythicMobs, nightcore, packetevents, PlaceholderAPI, Plan, PlayerAuctions, PoaSkRewritev2, ProtocolLib, Shopkeepers, SkBee, SkQuery, Skript, skript-gui, skript-placeholders, spark, SunLight, TAB, Tebex, TradeSystem, Vault, ViaBackwards, ViaVersion, WorldGuard, ZNPCsPlus

Purpur version 1.20.6-2233-0d6766e (latest)

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried a build from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Sep 9, 2024

Platform: 1.20.6--2233--0d6766e%20%28MC%3A%201.20.6%29
ViaVersion (5.0.4-SNAPSHOT): 3 commits behind master
ViaBackwards(5.0.4-SNAPSHOT): 1 commits behind master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

@Barvalg Barvalg added the invalid label Sep 9, 2024
@Barvalg Barvalg closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
@Boxeyy
Copy link
Author

Boxeyy commented Sep 10, 2024

@Barvalg
Copy link
Member

Barvalg commented Sep 10, 2024

Platform: 1.20.6--2233--0d6766e%20%28MC%3A%201.20.6%29
ViaVersion (5.0.4-SNAPSHOT): Even with master
ViaBackwards(5.0.4-SNAPSHOT): Even with master

@Barvalg Barvalg reopened this Sep 10, 2024
@Barvalg Barvalg removed the invalid label Sep 10, 2024
@Incluuu
Copy link

Incluuu commented Sep 13, 2024

I have the same problem

@FlorianMichael
Copy link
Member

image
This is a MC 1.20.4 client on a 1.20.6 Paper server.
I cannot reproduce your issue, are you sure it still happens with latest Via* plugins?

@Boxeyy
Copy link
Author

Boxeyy commented Sep 18, 2024

Try it with items that have custom attributes in villager shops (new 1.20.6 ones and old ones). Still happens

@alexcastro1919
Copy link

Happens for me on 1.21.1 server with 1.20.6 client

@Incluuu

This comment was marked as spam.

@negativems
Copy link

negativems commented Nov 4, 2024

There is a real problem on this. When you try to trade on client version 1.20.4 and below an item that have custom name it show the result invisible but you can click on it and it works. On above versions works fines.

Image from Gyazo

Specs:
Paper: 1.21
ViaVersion: 5.1.1
ViaBackwards: 5.1.1

@Kichura
Copy link
Member

Kichura commented Nov 4, 2024

While not reproducable with vanilla villagers, Shopkeepers like this one and custom villagers from datapacks have broken outputs - therefore it is a problem.

@TZ122
Copy link

TZ122 commented Nov 4, 2024

I am having the same issue 5.1.1 Via* and ShopKeepers plugin.

@negativems
Copy link

Has there been any progress on this?

@TZ122
Copy link

TZ122 commented Nov 24, 2024

Any update on this issue?
Thanks

@Hatefsf
Copy link

Hatefsf commented Nov 28, 2024

please fix 🫡

@ViaVersion ViaVersion locked as spam and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

9 participants