Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert database DataRow into MigrationType format #24

Open
vitaliimelnychuk opened this issue Dec 20, 2019 · 1 comment
Open

convert database DataRow into MigrationType format #24

vitaliimelnychuk opened this issue Dec 20, 2019 · 1 comment
Assignees
@svirgunvolodia
Labels
help wanted Extra attention is needed

Comments

@vitaliimelnychuk
Copy link
Contributor

Now, we've responded with Promise<object> from database
https://github.com/WiseEngineering/crispy-cli/blob/master/src/models/migrations.ts#L14-L22

Will be good to have Typescript types like Promise or array of migration
@vitaliimelnychuk vitaliimelnychuk added the help wanted Extra attention is needed label Dec 20, 2019
@vitaliimelnychuk
Copy link
Contributor Author

consider about http://knexjs.org/#typescript-support
looks like it could be helpful even we don't use our database a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svirgunvolodia svirgunvolodia

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaliimelnychuk @svirgunvolodia