Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command K shortcut to display change link name prompt no longer works #14

Open
zendude213 opened this issue Mar 14, 2021 · 6 comments
Open

Comments

@zendude213
Copy link

Usually if you wanted to add hyperlink to a text, you would select text and hit ⌘+K on the mac. This will show a contextual prompt where you can then put in the link and change the display of the text. This can also be done for hyperlinks.

This used to work. However, when hitting the hot key, it now always goes to the page switcher view.

I figured out that the Vimflowy extension was causing this by simply disabling it

@Wojnach
Copy link
Owner

Wojnach commented Mar 14, 2021

ty for the bug report! :)

It should be working now. e1c52ad

The chrome extension will be updated shortly. Will be bumped up to Version 0.0.4.1

Please let me know if it works! I don't have a MAC around so I can't test it myself :(

@Wojnach
Copy link
Owner

Wojnach commented Mar 14, 2021

added another fix for this in 757f8e0

  1. have text selected while in Insert mode
  2. prompting the hyperlink editor by pressing cmd-k
  3. finishing edit by pressing enter.

Should now also work.

@zendude213
Copy link
Author

Thanks. Tested and it now works. Wonder if it's possible to also change the color of the cursor or basically anything that would make it easier to see. Whenever I switch to Normal mode and begin navigating vertically (e.g. "j" or "k) or horizontally, I tend to lose my place

@Wojnach
Copy link
Owner

Wojnach commented Mar 16, 2021

Nice!

Custom cursor color can be added by injecting the following .css code when browsing the the Workflowy domain:

::selection
{
  color: #FDF6E3;
  background-color: #278BD2 !important;   
}

You can do this via the chrome extension "Stylish" for example.

But yes, I agree, the original Workflowy cursor color can be hard to see when navigating around.

The cursor color, used in Vimflowy, is the same color used when selecting text on the Workflowy website - because that is what it is actually doing when you navigate around in normal mode.

The selection color should change as you swap between different Workflowy themes, which you can do by going to Settings in Workflowy, so try out the Dark theme for example and see if it feels better.

Once you got the "stylish" extension working you can try custom themes others have scripted. Here are ports of the "Solarized" themes for workflowy:
https://github.com/Wojnach/WorkflowySolarized

The "Yellow" theme has a really clear and juicy cursor color:
https://github.com/Wojnach/WorkflowySolarized/blob/master/WorkflowySolarized_LightYellow.css

@Wojnach
Copy link
Owner

Wojnach commented Mar 16, 2021

Vimflowy doesn't have an option to change the cursor color as that feels like something seperate from what the extension was initally supposed to do.

@zendude213
Copy link
Author

Thanks appreciate this! Actually checked your solarized dark... seems to not work with Stylus... I think it's because you have some lines prefixed with "//" -- Not sure if I should remove "//" as I'm not clear how it will affect your design intent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants