Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boards #8

Open
8utl3r opened this issue Jun 14, 2020 · 4 comments
Open

Add support for boards #8

8utl3r opened this issue Jun 14, 2020 · 4 comments

Comments

@8utl3r
Copy link

8utl3r commented Jun 14, 2020

When you use boards there isn't a way to jump between the board columns, it just treats the first one as if it were the only one.

@Wojnach
Copy link
Owner

Wojnach commented Jun 22, 2020

This might be solvable by rewritting the navigational part of the extension to use the workflowy API instead. The current navigational code is quite old and it's based on how the Workflowy page was built years ago.

I'll take a look at it in the coming weeks.

In the meantime; one way to jump between board columns is to use the "ctrl-j" EasyMotion feature. Although the letters aren't visible until you hover over the anchor point for that specifc node.

@8utl3r
Copy link
Author

8utl3r commented Jun 22, 2020

Oh crap, I (literally) didn't even see that! Honestly, getting that to show up visibly might be the best fix right there. It kind of follows a nice mental model if lists go up and down but you have to jump columns. It makes intuitive sense.

@Wojnach
Copy link
Owner

Wojnach commented Jun 22, 2020

yeah hopefully it'll be easy to make the letters visible even with boards. I'd have to inspect the html code to see what they are doing. My implementation of the JumpTo is very simple. I just create a circle filled with same color as the background and then write a letter ontop of it. I suspect the boards has another div layer which is blocking the letter... Or I'm simply injecting the html code at the wrong layer. I dunno, we'll see! :)

@Wojnach
Copy link
Owner

Wojnach commented Aug 9, 2020

I took a look at the easyJump letter not being visible. I couldn't find a clean way to do it. We either have to manipulate their CSS to make the bullets visible again, during the jump. Or attach the letter to some other div that is visible, but then it has to be placed at an offset to ensure that it doesn't overlap the hidden bullet, which requires us to make assumption of visual design - which is prone to change. I'd rather try to find a different solution that doesn't require us to update the code as soon as they update their CSS. Hopefully there will be a better solution available next time we look at this problem.

Giving full movement support to boards would be nice, but it requires a rather significant refactor + a lot of testing to ensure that the change doesn't break any existing stuff. I'll get around to it eventually, but it will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants