Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete and Edit Block Patterns from the Post/Page Editor Screen #68768

Open
kohheepeace opened this issue Jan 19, 2025 · 2 comments
Open

Delete and Edit Block Patterns from the Post/Page Editor Screen #68768

kohheepeace opened this issue Jan 19, 2025 · 2 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.

Comments

@kohheepeace
Copy link

kohheepeace commented Jan 19, 2025

What problem does this address?

I would like the ability to delete and edit Block Patterns directly within the Editor. Currently, the UI either does not support this functionality or makes it very unclear. Additionally, redirecting users to a separate Site Editor page does not provide a good user experience.

1- Synced Pattern displays an edit link to the original.
Image

2- Unsynced Pattern does not show an edit link to the original.
Image

3- ❌ From the Post/Page Editor, I can't find a link to delete a pattern, which I have unwantedly or
mistakenly created.

What is your proposed solution?

Enable the deletion and editing of Block Patterns directly within the Post/Page Editor.

Related Core support request

Image

https://wordpress.org/support/topic/how-to-delete-patterns-in-gutenberg/

It is a pretty bad UX to have to go to "Appearance → Editor" for just delete/edit a Pattern, as shown on this support page.
https://wordpress.com/support/wordpress-editor/create-a-pattern/#delete-a-pattern

@kohheepeace kohheepeace added the [Type] Enhancement A suggestion for improvement. label Jan 19, 2025
@kohheepeace kohheepeace changed the title I want to be able to delete and edit Block Patterns from the Post/Page Editor screen. Allow Deleting and Editing Block Patterns from the Post/Page Editor Screen Jan 19, 2025
@kohheepeace kohheepeace changed the title Allow Deleting and Editing Block Patterns from the Post/Page Editor Screen Delete and Edit Block Patterns from the Post/Page Editor Screen Jan 19, 2025
@Rishit30G
Copy link
Contributor

Thanks for sharing the issue,

I do understand that having option to edit/delete from the post would be great idea, but I have some suggestions for the points mentioned, sharing them below:

For point 1:
Synced patterns are highly sensitive. Any changes made directly in the editor are reflected across the entire website, which can lead to unintended consequences. Implementing a redirection provides users with clarity and caution, ensuring they understand the impact of their actions. It prioritises caution over convenience.

For point 2:
I agree with this point, having option to "Edit the Original" in unsync pattern would be great to maintain consistency
If we have included an async pattern in the editor, we should also get some text that displays the same just like "Synced Pattern" in the left panel and toolbar
Moreover I could also see that an async pattern can again be created into an unsync/sync pattern, don't know if that seems right
Sharing a screencast:

Screen.Recording.2025-01-20.at.8.59.42.AM.mov

For point 3:
I’d like to emphasize again on the delicate nature of the synced pattern, having a delete option right from the editor can lead to problems over the whole website if not done carefully. However for unsync pattern this can be the cards maybe, but the question would again arise over consistency that when all the operations for patterns are being done from the editor UI then why create exception for unsync pattern ?

Sharing a screencast to better showcase all the 3 pointers of the issue:

Screen.Recording.2025-01-20.at.8.42.21.AM.mov

This is just my take on this issue, I would appreciate discussion/constructive criticism on the same 🙇🏻

Thanks

@kohheepeace
Copy link
Author

kohheepeace commented Jan 20, 2025

@Rishit30G Thank you for sharing your views.
’ Synced patterns are highly sensitive.’ => Yes. I agree with this.

However, I think this can be solved by implementing a confirmation modal UI that allows the slug of the synced pattern to be entered within the Post/Page Editor as well.

Confirm Modal for deleting github repositories. Implementing a UI like this would reduce the number of accidental deletions.
Image

I consistently believe that, from a UX standpoint, it would be better to enable the direct deletion and editing of block patterns within the post/page editor.

@t-hamano t-hamano added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants