Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the File_Editor_URL Traits to use a single filter instead of two. #314

Open
mukeshpanchal27 opened this issue Oct 31, 2023 · 0 comments
Open

Refactor the File_Editor_URL Traits to use a single filter instead of two. #314

mukeshpanchal27 opened this issue Oct 31, 2023 · 0 comments
Labels
[Type] Enhancement A suggestion for improvement of an existing feature

Comments

@mukeshpanchal27
Copy link
Member

Followup: #298 (comment)

Currently, the File_Editor_URL Traits codebase unconditionally passes the line parameter, which seems to be an unnecessary operation. There's a need for a more thoughtful approach to change this behaviour. In addition, it appears that the two filters (wp_plugin_check_validation_error_source_file_editor_url_template, wp_plugin_check_validation_error_source_file_path) in use are overly complex, and there might be an opportunity to streamline them into a single filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mukeshpanchal27