Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display the ongoing Event Info to people who already attend it #304

Closed
akirk opened this issue May 27, 2024 · 1 comment
Closed

Only display the ongoing Event Info to people who already attend it #304

akirk opened this issue May 27, 2024 · 1 comment
Assignees

Comments

@akirk
Copy link
Member

akirk commented May 27, 2024

Currently not reproducible but it looks like we display the link of #114 to people who are not attending.

@akirk akirk added this to the RSVP & Moderation milestone May 27, 2024
@akirk akirk assigned psrpinto and akirk and unassigned psrpinto May 27, 2024
@akirk
Copy link
Member Author

akirk commented May 27, 2024

I believe we had a bug that was fixed with #283 cc @psrpinto

We called get_current_events_for_user() with an empty array of events:

$this->attendee_repository->get_events_for_user( $user_id ),
so that we then don't filter by post_ids:
if ( ! empty( $filter_by_ids ) ) {
$args['post__in'] = $filter_by_ids;
}

Leading to the query returning all current events if a user had not attended any events before.

@akirk akirk closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants