Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

Remove extra before filter in ApplicationController #1072

Closed
orenyk opened this issue Dec 29, 2014 · 1 comment · Fixed by #1073
Closed

Remove extra before filter in ApplicationController #1072

orenyk opened this issue Dec 29, 2014 · 1 comment · Fixed by #1073
Assignees
@orenyk
Labels
diff: 1 pri: 1 type: enhancement
Milestone
5.0.0

Comments

@orenyk
Copy link
Contributor

orenyk commented Dec 29, 2014

There's a before filter used in ReservationsController called require_login that is basically superseded by all of the Devise work implemented in #2. I think we can safely take it out, just opening this for confirmation.
@orenyk orenyk added this to the 4.2.0 milestone Dec 29, 2014
@orenyk
Copy link
Contributor Author

orenyk commented Dec 29, 2014

Done (including references in spec), opening PR.

@orenyk orenyk self-assigned this Dec 29, 2014
@orenyk orenyk mentioned this issue Dec 29, 2014
Merged
squidgetx added a commit that referenced this issue Jan 2, 2015
@squidgetx
Merge pull request #1073 from YaleSTC/1072_cleanup_before_filter
7216dea 
#1072 Cleanup Before Filter
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@orenyk orenyk

Labels
diff: 1 pri: 1 type: enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

#1072 Cleanup Before Filter YaleSTC/reservations
1 participant
@orenyk