Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add "Reset speed" button #661

Open
ShawkMusic opened this issue Oct 21, 2024 · 6 comments
Open

[Feature Request] Add "Reset speed" button #661

ShawkMusic opened this issue Oct 21, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ShawkMusic
Copy link

A button in between the "speed up" and "slow down" buttons that resets the speed back to 1. It could also change the speed by hovering over it and scrolling. Ideally, this button should also show what the current speed of the video is.

Here's an example mockup:
image

It would also be nice to reset the speed quickly and easily by clicking the left mouse button while holding the scroll wheel speed control modifier key (Alt, Ctrl, or Shift)

@VampireChicken12
Copy link
Member

@ShawkMusic Thanks for suggesting

@VampireChicken12 VampireChicken12 changed the title Add "Reset speed" button [Feature Request] Add "Reset speed" button Oct 21, 2024
@VampireChicken12 VampireChicken12 added the enhancement New feature or request label Oct 21, 2024
@mKay00
Copy link

mKay00 commented Oct 24, 2024

+1
I might add that it would be nice to reset the speed to the Player speed set in the extension options. e.g. I have the speed usually at 1.5, sometimes I want to increase the speed to fly through the video and when an interesting part comes, I want to reset it with a click on the button to the default 1.5

@VampireChicken12
Copy link
Member

I will look into implementing this

@livingflore livingflore self-assigned this Dec 5, 2024
@livingflore
Copy link
Member

i'd rather add some motion like double clicking the speed button to reset the speed depending on what it is now:
if speed < 1 and you double click speed up, it's going to bring it back to 1, and if it's >= 1, double click will bring speed to 4 (or whatever you set as a max speed)
same with speed down, if speed < 1 double click will bring it to 0.25, and if it's > 1 it'll reset it back to 1

really not in favor of adding another button as it's going to look clogged especially if there's another button(s) already present

@ShawkMusic
Copy link
Author

i'd rather add some motion like double clicking the speed button to reset the speed depending on what it is now: if speed < 1 and you double click speed up, it's going to bring it back to 1, and if it's >= 1, double click will bring speed to 4 (or whatever you set as a max speed) same with speed down, if speed < 1 double click will bring it to 0.25, and if it's > 1 it'll reset it back to 1

What if I want to quickly set the speed to a specific high number? I have to wait for the double click cooldown between every single click?

Also, having the functionality behind a button that changes based on the situation instead of just having one simple, reliable button that always does the same thing the same way. Seems kinda confusing and not great UX.

really not in favor of adding another button as it's going to look clogged especially if there's another button(s) already present

Every other button can already be toggled on and off in the addon's settings. We can make the Reset Speed button toggleable as well.

Also, I put the buttons on the left side just for the mockup just because that's where it is by default, but I usually put it on the right side and I notice it looks a lot better there.

@livingflore
Copy link
Member

We can make the Reset Speed button toggleable as well.

that would do, sure, i misunderstood your suggestion a bit and thought that reset speed should be with playback speed buttons together as a single feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

4 participants