Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback speed control way too sensitive on trackpad #698

Open
theosib opened this issue Nov 26, 2024 · 6 comments
Open

Playback speed control way too sensitive on trackpad #698

theosib opened this issue Nov 26, 2024 · 6 comments

Comments

@theosib
Copy link

theosib commented Nov 26, 2024

Describe the bug
I like how we can control the playback speed using the control key and the mouse wheel. But when trying to do the same on a trackpad (two finger scroll on my Mac), the control is basically impossible to use, because the tiniest amount of scroll results in a wild speed change.

To Reproduce

  1. Use a Mac laptop
  2. Hold control
  3. Use two-finger scroll gesture

Expected behavior
Playback speed should change smoothly and not jump wildly.

Desktop (please complete the following information):

  • OS: macOS
  • Chrome
  • Version 130.0.6723.117 (Official Build) (arm64)

Additional context
It may also be necessary to include an alternate input method. For example, in the control panel for this extension, there is a Playback speed section that says, "Speed variation when rotating the mouse wheel or when clicking the speed buttons “-” and “+”:
0.1", but there are no actual “-” and “+” speed buttons anywhere.

@VampireChicken12
Copy link
Member

@theosib Thank you for making this issue. We will look into to it as soon as possible. I suspect this is an issue on any laptop trackpad because of the sensitive nature of them.

@VampireChicken12
Copy link
Member

when clicking the speed buttons “-” and “+”: 0.1", but there are no actual “-” and “+” speed buttons anywhere. They need to be enabled, The extension doesn't come with opinionated defaults. Once the playback speed buttons are enabled they will show on the left side of the player controls by default. @theosib

@VampireChicken12
Copy link
Member

We have considered adding an option to load a default configuration that has some stuff enabled by default. But as of right now there is no planned release of that.

@VampireChicken12
Copy link
Member

@theosib I started working on fixing this issue. I am unable to test it myself because I don't have a laptop. I'm going to have @livingflore test it when he is free. Once I fix it, I'll work on a few more fixes that need to be done and then release a new version of the extension.

@theosib
Copy link
Author

theosib commented Dec 2, 2024

I really like the new feature to change the speed change step size. This way I can make it smaller for the trackpad and larger for the mouse. Thanks!

@VampireChicken12
Copy link
Member

VampireChicken12 commented Dec 3, 2024

@theosib

I really like the new feature to change the speed change step size. This way I can make it smaller for the trackpad and larger for the mouse. Thanks!

That isn't a new feature just one you weren't aware of. I am still working on improving the sensitivity for trackpads. I haven't released anything as of yet.

@VampireChicken12 VampireChicken12 moved this to In Progress in YouTube Enhancer Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants