Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double Check Egg/Larva Selection Logic #16

Open
ZephyrBlu opened this issue Jan 20, 2021 · 0 comments
Open

Double Check Egg/Larva Selection Logic #16

ZephyrBlu opened this issue Jan 20, 2021 · 0 comments

Comments

@ZephyrBlu
Copy link
Owner

This looks kind of suspect: https://github.com/ZephyrBlu/zephyrus-sc2-parser/blob/master/zephyrus_sc2_parser/events/selection_event.py#L388

From memory it occurs when you're training units, so that's why it doesn't happen for any other morph event but something seems odd.

I can't remember if it's actually a morph from Larva -> Egg or it's a new GameObj.

Either way, shouldn't take long to confirm and then document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZephyrBlu