Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The modelgen subpackage is too specialized. #1

Open
a093130 opened this issue Apr 23, 2022 · 1 comment
Open

The modelgen subpackage is too specialized. #1

a093130 opened this issue Apr 23, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@a093130
Copy link
Owner

a093130 commented Apr 23, 2022

This package was developed specifically for Low-Thrust GMAT scripts using Alfano Transfers. Need to refactor such that a more general class of GMAT models may be generated. Suggest the family of LinkBudget models may be a point of variation.

@a093130 a093130 added the enhancement New feature or request label Jun 16, 2022
@a093130
Copy link
Owner Author

a093130 commented Jun 16, 2022

modelpov.py has two accessor functions which return a dictionary of GMAT resource names to worksheet table names and named ranges. As such, this python file must be modified for each variation. Two ideas for refactoring, (a) read each dictionary from a json file, we know how to map a json file to a dictionary (see controls.py). (b_ encapsulate these functions in a python classdef from which additional accessors or methods can be derived. Leave the original modelpov.py code in-place in the parent class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants