Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load issues for token length >= 128 #21

Open
JakeStanger opened this issue Apr 18, 2020 · 1 comment
Open

load issues for token length >= 128 #21

JakeStanger opened this issue Apr 18, 2020 · 1 comment

Comments

@JakeStanger
Copy link

If you attempt to load a previously saved chain where one of the tokens is >= 128 characters, the yaml parser throws an error that the key does not exist. Saving the chain to yaml does not have this problem.

I don't think this will be easy to fix, since the problem lies with the limits of yaml. Instead, either in feed or save, I believe an error should be thrown to prevent unloadable chains from ever been saved.

@aatxe
Copy link
Owner

aatxe commented Jul 20, 2020

I've just bumped the version of serde_yaml, so it is possible that changes on their end might have resulted in error production on serialization since the result is not a well-formed yaml file. If this is not the case, I would welcome a pull request that added a well-formedness check to save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants