From 74cba6f05f887b1b63086fec2a215a60854fc466 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Tue, 5 Mar 2024 19:36:01 +0530 Subject: [PATCH 1/5] incremented lib versions for laravel-echo --- package.json | 2 +- src/connector/ably-connector.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 0b63d2cf..8ee3a66c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@ably/laravel-echo", - "version": "1.0.3", + "version": "1.0.4", "description": "Laravel Echo library for beautiful Ably integration", "keywords": [ "laravel", diff --git a/src/connector/ably-connector.ts b/src/connector/ably-connector.ts index 46ab61ad..75b97634 100644 --- a/src/connector/ably-connector.ts +++ b/src/connector/ably-connector.ts @@ -11,7 +11,7 @@ export class AblyConnector extends Connector { /** * The laravel-echo library version. */ - static LIB_VERSION = '1.0.3'; + static LIB_VERSION = '1.0.4'; /** * The Ably instance. From b11b2125d622a77f7acfd40d639e1d8e68241fa8 Mon Sep 17 00:00:00 2001 From: sachin shinde Date: Tue, 5 Mar 2024 14:19:38 +0000 Subject: [PATCH 2/5] updated CHANGELOG-ABLY.md --- CHANGELOG-ABLY.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/CHANGELOG-ABLY.md b/CHANGELOG-ABLY.md index e3b7a039..603bd25e 100644 --- a/CHANGELOG-ABLY.md +++ b/CHANGELOG-ABLY.md @@ -1,5 +1,19 @@ # Changelog +## [v1.0.4](https://github.com/ably-forks/laravel-echo/tree/ably-echo-1.0.4) + +**Closed issues:** + +- Update README to use ably-js version \< 2.0 [\#34](https://github.com/ably-forks/laravel-echo/issues/34) +- customInternalAttach -\> authorize -\> errCallback undefined? [\#29](https://github.com/ably-forks/laravel-echo/issues/29) +- Doesn't work with Laravel Sanctum [\#26](https://github.com/ably-forks/laravel-echo/issues/26) + +**Merged pull requests:** + +- Fix laravel echo version [\#33](https://github.com/ably-forks/laravel-echo/pull/33) ([sacOO7](https://github.com/sacOO7)) +- Fix channel preattach errCallback null check [\#31](https://github.com/ably-forks/laravel-echo/pull/31) ([sacOO7](https://github.com/sacOO7)) +- Added explicit section to work with laravel sanctum [\#27](https://github.com/ably-forks/laravel-echo/pull/27) ([sacOO7](https://github.com/sacOO7)) + ## [v1.0.3](https://github.com/ably-forks/laravel-echo/tree/ably-echo-1.0.3) [Full Changelog](https://github.com/ably-forks/laravel-echo/compare/ably-echo-1.0.2...ably-echo-1.0.3) From 9cd143341958b3bdcd1d8ea020f6d0cb40f57818 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Tue, 5 Mar 2024 19:50:11 +0530 Subject: [PATCH 3/5] Updated README for the proper release process --- .github/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/README.md b/.github/README.md index 1e2ef45b..be8dae6f 100644 --- a/.github/README.md +++ b/.github/README.md @@ -131,7 +131,7 @@ This library uses [semantic versioning](http://semver.org/). For each release, t 4. Run [`github_changelog_generator`](https://github.com/github-changelog-generator/github-changelog-generator) to automate the update of the [CHANGELOG-ABLY.md](../CHANGELOG-ABLY.md). This may require some manual intervention, both in terms of how the command is run and how the change log file is modified. Your mileage may vary: - The command you will need to run will look something like this: `github_changelog_generator -u ably-forks -p laravel-echo --since-tag ably-echo-1.0.3 --output delta.md --token $GITHUB_TOKEN_WITH_REPO_ACCESS`. Generate token [here](https://github.com/settings/tokens/new?description=GitHub%20Changelog%20Generator%20token). - Using the command above, `--output delta.md` writes changes made after `--since-tag` to a new file. - - The contents of that new file (`delta.md`) then need to be manually inserted at the top of the `CHANGELOG.md`, changing the "Unreleased" heading and linking with the current version numbers. + - The contents of that new file (`delta.md`) then need to be manually inserted at the top of the (https://github.com/github-changelog-generator/github-changelog-generator) to automate the update of the [CHANGELOG-ABLY.md](../CHANGELOG-ABLY.md), changing the "Unreleased" heading and linking with the current version numbers. - Also ensure that the "Full Changelog" link points to the new version tag instead of the `HEAD`. 5. Commit generated [CHANGELOG-ABLY.md](../CHANGELOG-ABLY.md) file at root. 6. Make a PR against `main`. From 4e68b309551a7ba14633e9ca859c4803181b4e7e Mon Sep 17 00:00:00 2001 From: sachin shinde Date: Tue, 5 Mar 2024 14:23:07 +0000 Subject: [PATCH 4/5] updated CHANGELOG-ABLY.md --- CHANGELOG-ABLY.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG-ABLY.md b/CHANGELOG-ABLY.md index 603bd25e..60523980 100644 --- a/CHANGELOG-ABLY.md +++ b/CHANGELOG-ABLY.md @@ -2,6 +2,8 @@ ## [v1.0.4](https://github.com/ably-forks/laravel-echo/tree/ably-echo-1.0.4) +[Full Changelog](https://github.com/ably-forks/laravel-echo/compare/ably-echo-1.0.3...ably-echo-1.0.4) + **Closed issues:** - Update README to use ably-js version \< 2.0 [\#34](https://github.com/ably-forks/laravel-echo/issues/34) From b0503db402415c30cb90dff880f45d76e2e5362d Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Tue, 5 Mar 2024 20:19:52 +0530 Subject: [PATCH 5/5] Fixed readme release process for changelog section --- .github/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/README.md b/.github/README.md index be8dae6f..09418c58 100644 --- a/.github/README.md +++ b/.github/README.md @@ -131,7 +131,7 @@ This library uses [semantic versioning](http://semver.org/). For each release, t 4. Run [`github_changelog_generator`](https://github.com/github-changelog-generator/github-changelog-generator) to automate the update of the [CHANGELOG-ABLY.md](../CHANGELOG-ABLY.md). This may require some manual intervention, both in terms of how the command is run and how the change log file is modified. Your mileage may vary: - The command you will need to run will look something like this: `github_changelog_generator -u ably-forks -p laravel-echo --since-tag ably-echo-1.0.3 --output delta.md --token $GITHUB_TOKEN_WITH_REPO_ACCESS`. Generate token [here](https://github.com/settings/tokens/new?description=GitHub%20Changelog%20Generator%20token). - Using the command above, `--output delta.md` writes changes made after `--since-tag` to a new file. - - The contents of that new file (`delta.md`) then need to be manually inserted at the top of the (https://github.com/github-changelog-generator/github-changelog-generator) to automate the update of the [CHANGELOG-ABLY.md](../CHANGELOG-ABLY.md), changing the "Unreleased" heading and linking with the current version numbers. + - The contents of that new file (`delta.md`) then need to be manually inserted at the top of the [CHANGELOG-ABLY.md](../CHANGELOG-ABLY.md), changing the "Unreleased" heading and linking with the current version numbers. - Also ensure that the "Full Changelog" link points to the new version tag instead of the `HEAD`. 5. Commit generated [CHANGELOG-ABLY.md](../CHANGELOG-ABLY.md) file at root. 6. Make a PR against `main`.