Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why associating bugs failed #710

Closed
marusak opened this issue Sep 23, 2018 · 4 comments
Closed

Explain why associating bugs failed #710

marusak opened this issue Sep 23, 2018 · 4 comments

Comments

@marusak
Copy link
Collaborator

marusak commented Sep 23, 2018

If I use web UI to associate bug to a report often it happens that it is rejected but only a generic message is displayed. It is frustrating to use. Often the reason is different opsys, different components etc.
Lets show this information to user so it easier to understand what is happening.

@gayathrirajendar
Copy link
Contributor

Hello @marusak,

I am very much curious to understand this issue. Regarding this issue, When I click on Associate Bug and even put a random bug ID from googling rhel-bugzilla and submit, I get

Failed to fetch bug. + <Some additional message>.
&
Internal Server Error. This error has been logged and we will take care of it soon. Sorry.

I thought if I can read the error trace, I can understand something more. I tried the following,

In the docker folder, docker logs --follow faf. I couldn't see any additional logs there for the internal server error. Looks like I am checking it in the wrong place for internal server errors.

For the other error,

After searching in many places, I could see the same error messages in the end of the httpd_error_log file in /var/log/faf. For my different attempts of associating a bug, different error message has come and all the times the message came in the UI too.

With my little above understanding, if you can please direct and connect me with this issue, I will be so glad to take it up.

@marusak
Copy link
Collaborator Author

marusak commented Sep 26, 2018

Ok, sorry for delayed answer. I looked at it yesterday and I was surprised with the behavior, which was as you wrote, but different from what I thought it should be. To see this issue pick either fedora-bugzilla or rhel-bugzilla. The issue you are getting is related to #695.

When you try to pull random bug from bugzillas, you only get Failed to fetch bug message. You may try to pull the same bug in cmdline with sudo -E -u faf faf pull-bug to get better error messages. It should be easier to know why it is failing even from the webUI.

@gayathrirajendar
Copy link
Contributor

gayathrirajendar commented Sep 27, 2018

Thanks @marusak .

At this point, looks like the bug is coming as None without raising an error (exception) and so it directly goes here.

Can you please tell me where to find our print lines and debug logs in the container? It shall help me play with it and understand it better.

I am willing to work on and submit a PR for this issue. Shall I ?

@marusak
Copy link
Collaborator Author

marusak commented Sep 27, 2018

At this point, looks like the bug is coming as None without raising an error (exception) and so it directly goes here.

Yeah, I think you are right. We should probably raise exception or return error information (maybe as tuple?), why the function download_bug_to_storage_no_retry failed.

Can you please tell me where to find our print lines and debug logs in the container? It shall help me play with it and understand it better.

by print lines you mean? As if you put somewhere print("foo")? I am afraid that if you put it in faf/src/webfaf/reports.py it gets lost. I am not even sure about debug logs, as the server is not run in debug mode - but can be changed, see

elif "WEBFAF_ENVIRON_TEST" in os.environ:

When I want to see outputs from somewhere I just raise it, such as raise Exception("foo") and then it is in /var/log/faf/httpd_error_log. (You sometimes may need to restart the container (docker restart faf) so it takes effect.

I am willing to work on and submit a PR for this issue. Shall I ?

definitely

gayathrirajendar added a commit to gayathrirajendar/faf that referenced this issue Sep 28, 2018
When a report needs to be associated with a bug, failure
happens sometimes. The failure message is very generic
making it difficult for the user to understand the problem.
Now on failures, raised exception will contain appropriate
message that will be flashed in the web page helping the
user.

Resolves: abrt#710

Signed-off-by: Gayathri Rajendar <gayathriirajendar@gmail.com>
gayathrirajendar added a commit to gayathrirajendar/faf that referenced this issue Sep 28, 2018
Previously, on error in fetching the bug, it is returned as None
and the error was not sent upstream but only logged in the server.
We now expect an error instead of None on failures.

Related: abrt#710

Signed-off-by: Gayathri Rajendar <gayathriirajendar@gmail.com>
gayathrirajendar added a commit to gayathrirajendar/faf that referenced this issue Sep 28, 2018
Previously, on error while fetching a bug, it is returned as None
and the error was not sent upstream but only logged in the server.
We now expect an error instead of None on failures.

Related: abrt#710

Signed-off-by: Gayathri Rajendar <gayathriirajendar@gmail.com>
mkutlak pushed a commit that referenced this issue Oct 2, 2018
When a report needs to be associated with a bug, failure
happens sometimes. The failure message is very generic
making it difficult for the user to understand the problem.
Now on failures, raised exception will contain appropriate
message that will be flashed in the web page helping the
user.

Resolves: #710

Signed-off-by: Gayathri Rajendar <gayathriirajendar@gmail.com>
mkutlak pushed a commit that referenced this issue Oct 2, 2018
Previously, on error while fetching a bug, it is returned as None
and the error was not sent upstream but only logged in the server.
We now expect an error instead of None on failures.

Related: #710

Signed-off-by: Gayathri Rajendar <gayathriirajendar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants