Not supported for XCode10

[nikhilbfru]

No description provided.

[adolfo]

@nikhilbfru is this Xcode 10.2?

[anatoliykant]

yes, Xcode 10.2

[anatoliykant]

@aciidb0mb3r, @airmap
The framework tests on Xcode 10.2.1 do not pass.
For example, if I run the testPublishData() test in class SwiftMQTTTests, then I get an error.
At the same time on Xcode 10.1 test testPublishData() like all other tests pass.
I spent a lot of time to find the error and problem in func parse (_ read: StreamReader) -> MQTTPacket? in the MQTTPacketFactory.swift file, namely the data returned for Data (len: packetLength, from: read) (line 39).
Instead
▿ data: 2 bytes
                 - count: 2
                 ▿ pointer: 0x00007000069f6f20
                   - pointerValue: 123145413422880
                 ▿ bytes: 2 elements
                   - 0
                   - 1

Returns 0 in the second byte:
▿ data: 2 bytes
                 - count: 2
                 ▿ pointer: 0x00007000069f6f20
                   - pointerValue: 123145413422880
                 ▿ bytes: 2 elements
                   - 0
                   - 0
This byte corresponds to the response ID of the sent message.
Do you have any thoughts on how this can be fixed and is it a mistake for Apple engineers to use UnsafeMutablePointer(mutating:) or Data.init (count: len)?
Thanks

[kervich]

The issue can be reproduced with swift-5/5.1 toolchain and Xcode 9/10.1. It is my feeling that this has to do something with ABI stability that was introduced in swift-5, possibly changing whatever reading Swift.Data/NSData with Unsafe{Mutable{Raw}}Pointer yields. Even though SWIFT_VERSION is set to 4.x, it is still Swift-5 compiler that runs in 4.2 compatibility mode (as in lexical structure, not binary produced)

[anatoliykant]

The issue can be reproduced with swift-5/5.1 toolchain and Xcode 9/10.1. It is my feeling that this has to do something with ABI stability that was introduced in swift-5, possibly changing whatever reading Swift.Data/NSData with Unsafe{Mutable{Raw}}Pointer yields. Even though SWIFT_VERSION is set to 4.x, it is still Swift-5 compiler that runs in 4.2 compatibility mode (as in lexical structure, not binary produced)

I solved the problem.
THX

[kervich]

@anatoliykant, dare to share your solution?

[anatoliykant]

@anatoliykant, dare to share your solution?

I can lay out in the evening, hours through 8.

[Zubkov89]

Hi, @anatoliykant!
We faced the same issue, could you upload your fix, please!

[anatoliykant]

@kervich
@Zubkov89
I created a pull request - #44
You can wait, when it will accept or clone my branch.