Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ERC detection when events are included #153

Open
acuarica opened this issue Dec 17, 2024 · 0 comments
Open

Improve ERC detection when events are included #153

acuarica opened this issue Dec 17, 2024 · 0 comments
Labels
feature New feature or request

Comments

@acuarica
Copy link
Owner

acuarica commented Dec 17, 2024 •
edited
Loading

ERC detection does not play well when checking events. For example, the contract 0x67c66a5c36766ad11a16359e262c65a692da4923 is an ERC1155 contract. However, sevm does not detect it as such

$ sevm ercs 0x67c66a5c36766ad11a16359e262c65a692da4923
Detected ERCs
  - ERC165
  - ERC173

On the other hand, if the --no-check-events flag is used, it leads to the correct result

$ sevm ercs 0x67c66a5c36766ad11a16359e262c65a692da4923 --no-check-events
Detected ERCs
  - ERC1155
  - ERC1155MetadataURI
  - ERC165
  - ERC173
@acuarica acuarica added the feature New feature or request label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acuarica