Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding panics #9

Open
urandom opened this issue Oct 31, 2014 · 1 comment
Open

Avoiding panics #9

urandom opened this issue Oct 31, 2014 · 1 comment

Comments

@urandom
Copy link
Contributor

urandom commented Oct 31, 2014

Would it be possible to introduce a new method alongside Crawl, or change the existing one, so that an error is returned as the last argument rather than panicing? It'd be nice to obtain the error on any stage of the crawl (fetching, parsing, etc) so it can be handled accordingly.

@flexd
Copy link

flexd commented Aug 7, 2015

Looking at the code, there are a lot of places where errors should be returned instead of just logging or panic(). I agree that this is not very idiomatic, and should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants