From ec0be389f9b83738d363704904a72a6d92a5fb79 Mon Sep 17 00:00:00 2001 From: dylan Date: Wed, 23 Oct 2024 11:45:52 -0700 Subject: [PATCH] review changes --- cmd/flags/hnsw.go | 5 +++-- e2e_test.go | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd/flags/hnsw.go b/cmd/flags/hnsw.go index edefe7f..1ac3108 100644 --- a/cmd/flags/hnsw.go +++ b/cmd/flags/hnsw.go @@ -53,10 +53,11 @@ func NewHnswCachingFlags() *CachingFlags { } } +//nolint:lll // For readability func (cf *CachingFlags) NewFlagSet() *pflag.FlagSet { flagSet := &pflag.FlagSet{} - flagSet.Var(&cf.MaxEntries, HnswCacheMaxEntries, "Maximum number of entries to cache.") //nolint:lll // For readability - flagSet.Var(&cf.Expiry, HnswCacheExpiry, "A cache entry will expire after this amount of time has passed since the entry was added to cache") //nolint:lll // For readability + flagSet.Var(&cf.MaxEntries, HnswCacheMaxEntries, "Maximum number of entries to cache.") + flagSet.Var(&cf.Expiry, HnswCacheExpiry, "A cache entry will expire after this amount of time has passed since the entry was added to cache") return flagSet } diff --git a/e2e_test.go b/e2e_test.go index a277e0a..33b3eec 100644 --- a/e2e_test.go +++ b/e2e_test.go @@ -771,7 +771,7 @@ Batch Max Index Records*\,100000 Batch Index Interval*\,30s Batch Max Reindex Records*\,10000 Batch Reindex Interval*\,30s -Cache Max Entires*\,2000000 +Cache Max Entries*\,2000000 Cache Expiry*\,1h0m0s Healer Max Scan Rate / Node*\,1000 Healer Max Page Size*\,10000 @@ -791,7 +791,7 @@ Batch Max Index Records*\,100000 Batch Index Interval*\,30s Batch Max Reindex Records*\,10000 Batch Reindex Interval*\,30s -Cache Max Entires*\,2000000 +Cache Max Entries*\,2000000 Cache Expiry*\,1h0m0s Healer Max Scan Rate / Node*\,1000 Healer Max Page Size*\,10000