Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to install different versions of Spinnaker #2

Open
mafrosis opened this issue Nov 18, 2019 · 1 comment
Open

Make it possible to install different versions of Spinnaker #2

mafrosis opened this issue Nov 18, 2019 · 1 comment
Assignees

Comments

@mafrosis
Copy link

mafrosis commented Nov 18, 2019

It seems the current Spinnaker version is hard-coded:

https://github.com/afcastano/spinnaker-local-dev/blob/master/3-spinnaker.sh#L7
https://github.com/afcastano/spinnaker-local-dev/blob/master/3-spinnaker.sh#L31

@afcastano afcastano self-assigned this Nov 18, 2019
@afcastano
Copy link
Owner

Hey @mafrosis , you are pointing to the version of the helm chart, not the spinnaker version itself. You can modify the spinnaker version here:
https://github.com/afcastano/spinnaker-local-dev/blob/master/values.yaml#L2

However, it would be a good idea to be able to modify the helm chart version.
I did harcode it in the first place because the newer version requires a k8s version that is not supported by gke yet, so it wasn't working when I deployed.

I'll add some settings for the helm chart and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants