Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weekly and biweekly options to recurring transactions #67

Closed
roanutil opened this issue Oct 8, 2018 · 5 comments
Closed

Add weekly and biweekly options to recurring transactions #67

roanutil opened this issue Oct 8, 2018 · 5 comments

Comments

@roanutil
Copy link

roanutil commented Oct 8, 2018

Weekly and biweekly are both pretty basic options for recurring transaction intervals. There are likely more recurrence options needed but these two are simple to add and fundamental.

@roanutil roanutil closed this as completed Oct 8, 2018
@roanutil roanutil reopened this Oct 8, 2018
@simhnna
Copy link
Contributor

simhnna commented Oct 8, 2018

While I don't need them myself I have nothing against adding support for them. Although I guess that a more general recurrence system would be better. Cause the next will come and ask for 1. day of month, the next for the last workday,....

Do you have ideas on how to model this in a nice way?

@roanutil
Copy link
Author

roanutil commented Oct 8, 2018

I agree that there is room for making the recurring intervals more flexible. For now, I think most common cases are covered with these added. That's why I went ahead and added this issue and pull request. It's "drop in" so it costs nothing.

Right now, I'm working on issue #62. But once I make progress on that, I'll think more on how to better model this.

@roanutil
Copy link
Author

roanutil commented Oct 8, 2018

Something to note on how I added these options to the model. It will cause issues with any existing data in the database. As I added the new values in ascending order. So any previously created monthly transactions will now show as weekly. Considering it's still pre-release this may not be a big issue.

I didn't want to add them out of order. But it will cause issues as currently implemented.

@simhnna
Copy link
Contributor

simhnna commented Oct 8, 2018

yeah, that won't work... I'm using it in production :-)

let's see if we get somewhere in #62 and then tackle this one :-)

@roanutil
Copy link
Author

roanutil commented Dec 3, 2018

Issue will be addressed by current rework-recurrences branch. Closing

@roanutil roanutil closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants