Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rule names more descriptive in generated woke.yml #18

Open
bachand opened this issue Sep 23, 2021 · 1 comment
Open

Make rule names more descriptive in generated woke.yml #18

bachand opened this issue Sep 23, 2021 · 1 comment

Comments

@bachand
Copy link
Contributor

bachand commented Sep 23, 2021

Today generate_woke_config creates a new set of rules that are named airbnb-0, airbnb-1, etc. We should prefer human-readable names instead, like airbnb-whitelist, airbnb-dummy, as those names are easier to use with woke's inline ignore syntax.

# Clear
let url = URL(string: "www.noninclusive.com/whitelist")  // wokeignore:rule=airbnb-whitelist
# Less clear
let url = URL(string: "www.noninclusive.com/whitelist")  // wokeignore:rule=airbnb-0

Alternatively, the change to disable default rules lands (see get-woke/woke#132), we can use simple rules names that don't have an Airbnb prefix.

@caitlinelfring
Copy link

caitlinelfring commented Nov 27, 2021

Wanted to note that the feature to disable the default rules shipped in v0.17 of woke https://docs.getwoke.tech/rules/#disable-all-default-rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants