Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotifyOnPanic suppresses panic when notification fails #381

Open
GordonFremen opened this issue Dec 12, 2024 · 1 comment
Open

NotifyOnPanic suppresses panic when notification fails #381

GordonFremen opened this issue Dec 12, 2024 · 1 comment

Comments

@GordonFremen
Copy link

In NotifyOnPanic, the function returns normally instead of panicking if n.SendNotice returns an error. When this happens, the program returns an exit code of 0. This results in build pipelines, etc. proceeding normally and not halting due to a failure.

I suggest that panic(v) also be called in that error handling block instead of return.
@GordonFremen
Copy link
Author

PR created. #382

GordonFremen pushed a commit to GordonFremen/gobrake that referenced this issue Dec 12, 2024
NotifyOnPanic panics when n.SendNotice returns an error - Fixes airbr…
c7288e8 
…ake#381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GordonFremen