Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository should return Result #36

Closed
5 tasks
akdasa opened this issue Dec 10, 2022 · 0 comments · Fixed by #42
Closed
5 tasks

Repository should return Result #36

akdasa opened this issue Dec 10, 2022 · 0 comments · Fixed by #42
Assignees
@akdasa
Labels
documentation Improvements or additions to documentation

Comments

@akdasa
Copy link
Member

akdasa commented Dec 10, 2022 •
edited
Loading

depends on: #37

  • - [ ] Repository should not throw exceptions
  • Repository should return Result<Entity, Error>
  • Update documentation
  • Update tests
  • Update InMemoryRepository implementation
@akdasa akdasa self-assigned this Dec 10, 2022
@akdasa akdasa converted this from a draft issue Dec 10, 2022
@akdasa akdasa added the documentation Improvements or additions to documentation label Dec 10, 2022
@akdasa akdasa moved this from 🆕 New to 🔖 Ready in 📦 Framework Dec 10, 2022
@akdasa akdasa moved this from 🔖 Ready to 🏗 In progress in 📦 Framework Dec 10, 2022
akdasa added a commit that referenced this issue Dec 10, 2022
@akdasa
feat: repository should return Result
d35a7f8 
Fixes #36
@akdasa akdasa mentioned this issue Dec 10, 2022
Merged
akdasa added a commit that referenced this issue Dec 10, 2022
@akdasa
feat: repository should return Result (#42)
ef8fa5d 
* feat: repository should return Result
Fixes #36
Repository owner moved this from 🏗 In progress to ✅ Done in 📦 Framework Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akdasa akdasa

Labels
documentation Improvements or additions to documentation
Projects
📦 Framework
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: repository should return Result akdasa-studios/framework
1 participant
@akdasa