Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook payloads without a ref field always get skipped #23

Open
Slendy opened this issue May 2, 2024 · 1 comment
Open

Webhook payloads without a ref field always get skipped #23

Slendy opened this issue May 2, 2024 · 1 comment

Comments

@Slendy
Copy link

Slendy commented May 2, 2024

In my testing, I was attempting to trigger a workflow when a new registry package was published. No matter what I tried though the webhook would never trigger. After some digging, I discovered that the webhook payload doesn't contain a ref field which causes the ref check in shouldProcess to never return true. I got my situation to work by making the project ref nullable, but this is more of a temporary fix. Another potential solution could be checking that the ref field exists on the payload before checking it against the project ref.

@alexandru
Copy link
Owner

The project ref is used for selecting the right configuration to execute. In what cases is it null? And how do you see it behave?

Fixing this would probably require a configuration change. Any proposals?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants