New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pi is hardcoded in unit tests #190

Open

ashwalk33r opened this issue Apr 4, 2020 · 1 comment · May be fixed by #224

ashwalk33r commented Apr 4, 2020 •

edited

Loading

Why pi is hardcoded in https://github.com/alexei/sprintf.js/blob/master/test/test.js#L10 as var pi = 3.141592653589793 where Math.PI exists which returns same number? Why to hardcode it?

The text was updated successfully, but these errors were encountered:

ashwalk33r changed the title ~~pi is hardcoded in tests~~ pi is hardcoded in unit tests

tshinnic commented Jan 30, 2021

It is true that Math.PI has been present since ECMA-262, 1st edition, June 1997. Just needs a PR (hmm?)

sakamossan added a commit to sakamossan/sprintf.js that referenced this issue


          Fix test alexei#190

a5c28a8

sakamossan linked a pull request

that will close this issue

Fix to use constant Math.PI in test #224

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment