Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph generation broken in 0.2.0+ #64

Closed
trod-123 opened this issue Apr 23, 2020 · 1 comment
Closed

Graph generation broken in 0.2.0+ #64

trod-123 opened this issue Apr 23, 2020 · 1 comment

Comments

@trod-123
Copy link

trod-123 commented Apr 23, 2020

Firstly, thanks for your hard work developing this tool. It is a great resource for laying the groundwork of our refactoring project.

I've noticed that the graphs generated in the latest version 0.3.1 don't provide any useful information. I've noted a couple issues:

  1. Graphs do not show any class dependencies, but rather showcase function dependencies for each class (see representative sample below, I don't want to disclose too much but all my classes look something like this)
    image

  2. The generated analyzed.js file seems to be missing a whole bunch of classes (namely Activities)

My filters are defined as:

{
    "package-name": "[REDACTED]",
    "show-inner-classes": true, // if I set this to false, I wouldn't see anything generated in index.html or analyzed.js 
    "ignored-classes": [".*Dagger.*", ".*Inject.*", ".*ViewBinding$", ".*Factory$", ".*_.*", "^R$", "^R\\$.*"]
}

I'm running on a Windows 10 machine.

I really want to use this tool, and was wondering why the generated outputs differ widely from your screenshots, so I thought it might have broken in an update. Fortunately, I was able to generate the expected graphs using an older version 0.1.5. This seems to resolve the above 2 issues. All versions after 0.1.5 somehow broke the output.

That said, the filtering options available in 0.3.1 are super helpful, and I wish I was able to integrate those back into 0.1.5 since 0.1.5 is the latest version that somehow works properly. but for the time being, what I have generated using 0.1.5 is a great start.

Let me know if you need me to provide more info to help debug this issue. Thanks again!

@trod-123 trod-123 changed the title Graph generation broken in 0.1.5+ Graph generation broken in 0.2.0+ Apr 23, 2020
@trod-123
Copy link
Author

It looks like the fix outlined here solves this problem. I am running this on Windows: #60 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant