[Bug] all *_many methods don't work on Reth

[0xlosh]

Component

rpc

What version of Alloy are you on?

0.1/0.2

Operating System

Linux

Describe the bug

Following methods do not work with a reth node

    async fn call_many: not implemented
    
    async fn debug_trace_call_many(
        &self,
        txs: Vec<TransactionRequest>,
        block: BlockNumberOrTag,
        trace_options: GethDebugTracingCallOptions,
    )
    
    async fn trace_call_many<'a>(
        &self,
        request: TraceCallList<'a, N>,
    )

reason being that reth accepts different types

    async fn call_many(
        &self,
        bundle: Bundle,
        state_context: Option<StateContext>,
        state_override: Option<StateOverride>,
    )
    
     pub async fn debug_trace_call_many(
        &self,
        bundles: Vec<Bundle>,
        state_context: Option<StateContext>,
        opts: Option<GethDebugTracingCallOptions>,
    ) 
    
     pub async fn trace_call_many(
        &self,
        calls: Vec<(TransactionRequest, HashSet<TraceType>)>,
        block_id: Option<BlockId>,
    )

instead of Vec<TransactionRequest>, reth expects a Vec<Bundle> (debug_trace_call_many)
instead of BlockNumberOrTag, reth expects a StateContext (debug_trace_call_many)
instead of Vec<TraceType>, reth expects a HashSet<TraceType> (trace_call_many)

[mattsse]

@zerosnacks mind looking into this, we likely have wrong arg order here

[zerosnacks]

Spotted a discrepancy, specifically in debug_trace_call_many where the bundles parameter doesn't skip over block_override, incompatible with Vec<TransactionRequest>.

alloy/crates/rpc-types-eth/src/call.rs

Lines 11 to 12 in 067cc46

	/// Block overrides to apply
	pub block_override: Option<BlockOverrides>,

alloy/crates/provider/src/ext/debug.rs

Line 125 in 067cc46

txs: Vec<TransactionRequest>,

eth_callMany does not seem to be implemented in Alloy so that will have to be added in the eth_ namespace

trace_call_many implementation seems to be correct though it could possibly use BlockId instead of BlockNumberOrTag in the Alloy implementation depending on if BlockHash is supported by all clients

Testing effectively blocked until #1062 is implemented so I'm picking that up as a prerequisite

[0xlosh]

Spotted a discrepancy, specifically in debug_trace_call_many where the bundles parameter doesn't skip over block_override, incompatible with Vec<TransactionRequest>.

alloy/crates/rpc-types-eth/src/call.rs

Lines 11 to 12 in 067cc46

	/// Block overrides to apply
	pub block_override: Option<BlockOverrides>,

alloy/crates/provider/src/ext/debug.rs

Line 125 in 067cc46

txs: Vec<TransactionRequest>,

eth_callMany does not seem to be implemented in Alloy so that will have to be added in the eth_ namespace

trace_call_many implementation seems to be correct though it could possibly use BlockId instead of BlockNumberOrTag in the Alloy implementation depending on if BlockHash is supported by all clients

Testing effectively blocked until #1062 is implemented so I'm picking that up as a prerequisite

trace_call_many is wrong too because alloy wants a Vec<TraceType> but reth wants a HashSet<TraceType> since pub type TraceCallList<'a, N> = &'a [(<N as Network>::TransactionRequest, Vec<TraceType>)]; i think.
I also edited my first post, should be clearer now hopefully :)

[zerosnacks]

Now unblocked with #1062 merged

[zerosnacks]

Fixed debug_traceCallMany and trace_callMany in #1278

#1274 will add eth_callMany as it requires some more consideration