Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML publications don't use govuk-frontend grid classes #3329

Closed
andysellick opened this issue Sep 12, 2024 · 1 comment
Closed

HTML publications don't use govuk-frontend grid classes #3329

andysellick opened this issue Sep 12, 2024 · 1 comment

Comments

@andysellick
Copy link
Contributor

On pages like https://www.gov.uk/government/publications/car-show-me-tell-me-vehicle-safety-questions/car-show-me-tell-me-vehicle-safety-questions the columns use custom layout CSS despite being inside a govuk-grid-row, i.e.

  • left one quarter contents column is govuk-grid-column-one-quarter-from-desktop
  • right 3/4 column is main-content-container

I've done a quick test and replacing these with govuk-grid-column-one-quarter and govuk-grid-column-three-quarters seems to produce exactly the same result. There is another non-column element inside this grid row (see issue below) which may be related to this.

Possibly related to #3328
@matthillco
Copy link
Contributor

This is fixed in PR #3332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andysellick @matthillco