From afc857491ef59d050b0ae974d27fcc689d17c270 Mon Sep 17 00:00:00 2001
From: Tom Byers <tombaromba@gmail.com>
Date: Thu, 5 Sep 2024 22:33:20 +0100
Subject: [PATCH 1/3] Remove aria-hidden from search label

Hiding it with `aria-hidden` removes it from the
accessibilty tree, which also stops it labelling
the input textbox.

It also already has styles to hide it visually so
doesn't need it for that.
---
 lib/source/layouts/_search.erb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/source/layouts/_search.erb b/lib/source/layouts/_search.erb
index be33467d..ee0ccc4a 100644
--- a/lib/source/layouts/_search.erb
+++ b/lib/source/layouts/_search.erb
@@ -2,7 +2,7 @@
 <div class="search" data-module="search" data-path-to-site-root="<%= path_to_site_root config, current_page.path %>">
   <form action="https://www.google.co.uk/search" method="get" role="search" class="search__form govuk-!-margin-bottom-4">
     <input type="hidden" name="as_sitesearch" value="<%= config[:tech_docs][:host] %>"/>
-    <label class="govuk-label search__label" for="search" aria-hidden="true">
+    <label class="govuk-label search__label" for="search">
       Search (via Google)
     </label>
     <input

From 019efbca1db8d91058b7122cd6aeba8df1c187bc Mon Sep 17 00:00:00 2001
From: Tom Byers <tombaromba@gmail.com>
Date: Fri, 6 Sep 2024 14:57:10 +0100
Subject: [PATCH 2/3] Make search textbox type=search

Because it is. Like we do on www.gov.uk
---
 lib/source/layouts/_search.erb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/source/layouts/_search.erb b/lib/source/layouts/_search.erb
index ee0ccc4a..560bfd84 100644
--- a/lib/source/layouts/_search.erb
+++ b/lib/source/layouts/_search.erb
@@ -6,7 +6,7 @@
       Search (via Google)
     </label>
     <input
-      type="text"
+      type="search"
       id="search" name="q"
       class="govuk-input govuk-!-margin-bottom-0 search__input"
       aria-controls="search-results"

From 6814e7dec2c5de2644fc0cb37197ce1d41f0f703 Mon Sep 17 00:00:00 2001
From: Tom Byers <tombaromba@gmail.com>
Date: Tue, 17 Sep 2024 09:58:58 +0100
Subject: [PATCH 3/3] Update CHANGELOG

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8d5dd97b..98c9454b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - BREAKING: drop support for end-of-life Ruby versions 2.7 and 3.0. The minimum Ruby version is now 3.1.
 - Update gem dependencies.
 - Declare some missing indirect dependencies to prepare for Ruby 3.4. This also resolves some warnings about this at build time.
+- Remove aria-hidden from search label to let assistive technologies see its accessible name
 
 ## 3.5.0