Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to add a prefix to every metric #60

Open
TheElectronWill opened this issue Nov 12, 2024 · 4 comments
Open

Add an option to add a prefix to every metric #60

TheElectronWill opened this issue Nov 12, 2024 · 4 comments
Assignees
Labels
A:existing-plugin area: an existing plugin D:easy difficulty: easy (≤ 1 day of work) T:ux type: Enhancement of the user experience

Comments

@TheElectronWill
Copy link
Contributor

Suggested by Thomás:

I think the metrics names should start with something representative like alumet_* . This way if you have a time series database with multiple metrics from other sources, it is easily recognizable which ones are coming from alumet.

@TheElectronWill TheElectronWill added T:ux type: Enhancement of the user experience A:existing-plugin area: an existing plugin D:easy difficulty: easy (≤ 1 day of work) labels Nov 12, 2024
@guigomcha
Copy link
Contributor

I believe that this functionality would be very nice for our environment. At first glance it looks like it could be global for all plugins if we added a new option to the CLI and then checked it in AlumetPluginStart.create_metric and AlumetPluginStart.create_metric_untyped

Any suggestion or pointer ?

@TheElectronWill
Copy link
Contributor Author

It could be implemented without touching the core of Alumet, with a transform step that would change the metrics before they are exported via the outputs.

@guigomcha
Copy link
Contributor

@TheElectronWill could you assign the issue to me?

@TheElectronWill
Copy link
Contributor Author

Sure! Don't hesitate if you have questions regarding the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:existing-plugin area: an existing plugin D:easy difficulty: easy (≤ 1 day of work) T:ux type: Enhancement of the user experience
Projects
None yet
Development

No branches or pull requests

2 participants