Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization support #20

Open
amoraitis opened this issue Aug 17, 2019 · 11 comments
Open

Localization support #20

amoraitis opened this issue Aug 17, 2019 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed in progress up-for-grabs

Comments

@amoraitis
Copy link
Owner

amoraitis commented Aug 17, 2019

Anyone can improve the existing translations, feel free to extend.

Is your feature request related to a problem? Please describe.

We really should create a multilingual website. Thus an app like this will reach a wider audience

Describe the solution you'd like

We could definitely use localization as it is described in the docs
Using .resx files is a safe solution.

Describe alternatives you've considered
We could also use transifex

@amoraitis amoraitis added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers up-for-grabs labels Aug 17, 2019
@MetzeloS
Copy link
Contributor

MetzeloS commented Sep 2, 2019

Just made it possible to add localization to the app.
Temp change of the language can happen by adding "culture" attribute in the url
eg. http://localhost:47818/Todos/Home?culture=el-gr
Currently there is only 1 entry for English and Greek for testing purposes.
In order to extend it, we need to add new entries in the .resx files and then include them in the View files.

@amoraitis
Copy link
Owner Author

amoraitis commented Sep 2, 2019

Just made it possible to add localization to the app.
Temp change of the language can happen by adding "culture" attribute in the url
eg. http://localhost:47818/Todos/Home?culture=el-gr
Currently there is only 1 entry for English and Greek for testing purposes.
In order to extend it, we need to add new entries in the .resx files and then include them in the View files.

Your contirbution is just awesome, we can keep this issue open and make a list of languages we could add in the future.

@MetzeloS
Copy link
Contributor

MetzeloS commented Sep 3, 2019 via email

@amoraitis
Copy link
Owner Author

@MetzeloS yes you have the latest version, I merged your PR. I haven't noticed it the time I authored the comment. Thus I edited it.

@amoraitis amoraitis added duplicate This issue or pull request already exists in progress and removed duplicate This issue or pull request already exists labels Sep 4, 2019
@amoraitis amoraitis pinned this issue Oct 16, 2019
@karandesai28
Copy link
Contributor

Hello,
I have done translation of English to Hindi and I want to send Pull Request. Before that I want to see the preview, however localization isn't working on localhost. I tried appending "?culture=el-gr" to routes also but it kept showing English version only. Can any one please specify of what I could be missing?

@amoraitis
Copy link
Owner Author

Hello,
I have done translation of English to Hindi and I want to send Pull Request. Before that I want to see the preview, however localization isn't working on localhost. I tried appending "?culture=el-gr" to routes also but it kept showing English version only. Can any one please specify of what I could be missing?

Sorry for the late reply(I had a problem with my pc), let me look into that.

@amoraitis
Copy link
Owner Author

@karandesai28 Actually, localization is not widely used currently. You can add yours, see this. @MetzeloS referenced 1 localization string because it was the only one by that time(Its the title of the Home page). I will open a new issue for referencing localization strings instead of text.

Feel free to open your PR. Your changes will be merged.

@karandesai28
Copy link
Contributor

@karandesai28 Actually, localization is not widely used currently. You can add yours, see this. @MetzeloS referenced 1 localization string because it was the only one by that time(Its the title of the Home page). I will open a new issue for referencing localization strings instead of text.

Feel free to open your PR. Your changes will be merged.

Thank You. I didn't notice that. I have sent the pull request (#60)

@TaarnStar
Copy link
Contributor

Hi, I would like to add the localization for Italian and Croatian. Can I just fork the project or I need to do something before contributing? Thanks :)

@amoraitis
Copy link
Owner Author

Hi @TaarnStar, please go ahead and fork.🎊

@mhrnnoi
Copy link
Contributor

mhrnnoi commented Jul 17, 2023

Hi there! I noticed this issue and would be interested in contributing to the project by adding a Persian language translation. Is this issue still open, and would it be possible to add a Persian translation? I'd be happy to create a new .resx file for the Persian language. Please let me know if this would be helpful, and if there are any other guidelines or instructions I should follow. Thank you!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed in progress up-for-grabs
Projects
None yet
Development

No branches or pull requests

5 participants