Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI docker push step for PRs #169

Open
HarHarLinks opened this issue Feb 22, 2024 · 1 comment
Open

Fix CI docker push step for PRs #169

HarHarLinks opened this issue Feb 22, 2024 · 1 comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code security

Comments

@HarHarLinks
Copy link
Collaborator

PRs from forks (i.e. community contributions) don't have the right to the GHCR token. They would normally only push to PR container tags, which would be fine, but in theory it would be possibly to edit the CI definition and push to another tag, as PRs run the CI as it is defined on the PR branch.

What to do?

  • skip the step, because it's not that important to have a prebuilt container for each branch available to test it?
  • some yet unknown permission feature of github?
  • ?
@HarHarLinks HarHarLinks added bug Something isn't working github_actions Pull requests that update GitHub Actions code security labels Feb 22, 2024
@HarHarLinks
Copy link
Collaborator Author

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HarHarLinks