Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with latest JDK without extra setup #6125

Closed
LiamM32 opened this issue Jun 26, 2023 · 3 comments · Fixed by #6816
Closed

Allow building with latest JDK without extra setup #6125

LiamM32 opened this issue Jun 26, 2023 · 3 comments · Fixed by #6816
Labels
build Gradle [ci] enable "build tools" tests kind:feature A feature request

Comments

@LiamM32
Copy link

LiamM32 commented Jun 26, 2023

Description

Building the latest version with JDK 20 will fail. The README.md admits that this may happen on newer JDK versions. This should be fixed, so that one doesn't need to install an older JDK version just to compile NetBeans.

Use case/motivation

For ant build to run without errors when using JDK 20.

Related issues

No response

Are you willing to submit a pull request?

No

@LiamM32 LiamM32 added kind:feature A feature request needs:triage Requires attention from one of the committers labels Jun 26, 2023
@neilcsmith-net
Copy link
Member

The README also includes an explanation for this, and instructions for how to build with JDK 20. If you look at the GitHub actions workflows you'll also see how build is being tested on JDK 21 already.

I'm inclined to close this issue, but maybe someone has a thought on an alternative approach?

@neilcsmith-net neilcsmith-net removed the needs:triage Requires attention from one of the committers label Jun 27, 2023
@mbien
Copy link
Member

mbien commented Jun 29, 2023

in all honestly. If we don't get any advantage out of having the one (?) module built using gradle, we should revert it again to ant.

The migration away from ant seems far away still if that ever happens (is it worth the trouble?). It could also end up being maven and not gradle - not sure if that was decided already. Maven is apache where we have dev connections to and pretty much industry standard outside of android still.

Ultimately a project like NB benefits of being buildable and ideally also testable on EA builds to get early warnings.

more users with the same problem: #6612, #5836

@neilcsmith-net
Copy link
Member

@mbien "Gradle is just Ant with slightly better syntax" TM 😆

All (half) joking aside, I was under the impression there was a reason this had to be Gradle-based. If there isn't, then yes, let's get it changed back - Gradle approach to compatibility with newer JDKs is a PITA!

@mbien mbien added the build label Jun 29, 2023
@mbien mbien changed the title Allow building with JDK 20. Allow building with latest JDK without extra setup Oct 26, 2023
@mbien mbien added the Gradle [ci] enable "build tools" tests label Nov 13, 2023
@mbien mbien added needs:triage Requires attention from one of the committers and removed needs:triage Requires attention from one of the committers labels Dec 8, 2023
@mbien mbien linked a pull request Dec 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle [ci] enable "build tools" tests kind:feature A feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants