Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegmentPartitionMetadataManager unbounded logging #14695

Open
jadami10 opened this issue Dec 21, 2024 · 1 comment
Open

SegmentPartitionMetadataManager unbounded logging #14695

jadami10 opened this issue Dec 21, 2024 · 1 comment

Comments

@jadami10
Copy link
Contributor

#11599 added https://github.com/apache/pinot/blame/master/pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpartition/SegmentPartitionMetadataManager.java#L168-L172 for more logging. Internally, we're seeing this log show up almost 1B times per day over many tables.

My hypothesis is it's due to the fact that we have set

"segmentPartitionConfig": {
        "columnPartitionMap": {
          "<partition_col>": {
            "functionName": "Murmur",
            "numPartitions": 1000
          }
        }
      },

But this mapping doesn't actually match the underlying data. This is a different problem in Pinot where it's not always possible to express partitioning info used for the data in Pinot. But regardless of the cause, this log is way too high volume.

possible fixes:

  • change to DEBUG. Do we actually need this log?
  • should this ever log more than once per segment? shouldn't the online servers eventually match?
@Jackie-Jiang
Copy link
Contributor

Currently it is logged once per segment per assignment change (e.g. a new segment being pushed/deleted). We should aggregate them, and only log once for all segments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants