Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Support batch receive and ack #274

Closed
shibd opened this issue Jan 3, 2023 · 5 comments
Closed

[feature request] Support batch receive and ack #274

shibd opened this issue Jan 3, 2023 · 5 comments
Assignees

Comments

@shibd
Copy link
Member

shibd commented Jan 3, 2023

Motivation

You can refer to PIP-38.

Solution

We already support batch receive in the C++ client apache/pulsar-client-cpp#21, In the Node.js client side, we can wrap its interface for support.

@mguay22
Copy link

mguay22 commented Feb 22, 2023

Hi @shibd - was trying to give this a go and notice there are no methods regarding the new batching implementation in https://github.com/apache/pulsar-client-cpp/blob/main/lib/c/c_Consumer.cc

I was thinking the implementation would follow a similar pattern of calling methods found there in https://github.com/apache/pulsar-client-node/blob/master/src/Consumer.cc - am I completely off the mark?

Also would this implementation still require the use of ConsumerReceiveWorker? Thanks

@HasanHaghniya
Copy link

any updates?

@shibd
Copy link
Member Author

shibd commented Mar 18, 2023

was trying to give this a go and notice there are no methods regarding the new batching implementation in https://github.com/apache/pulsar-client-cpp/blob/main/lib/c/c_Consumer.cc

Yes, we need to support the batch receive method on the c interface first.

@shibd shibd self-assigned this Mar 20, 2023
@samwaterbury
Copy link

I saw that #357 was merged — I'm curious when the next release of the Nodejs Pulsar client might be? Or is there an outstanding todo for batch receive?

Thanks for all your contributions. 🙂

@mguay22
Copy link

mguay22 commented Feb 6, 2024

Looks like this just landed in v1.10.0. Thank you! We're eager to try it out and see performance benefits from the batching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants