Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Disable/Misconfigure the Eclipse launcher if project is not present on setup files #43

Open
d-gs opened this issue Nov 3, 2021 · 0 comments
Labels
Prio: Triage Triage Priority Status: Pending Issue or PR awaits response Type: Feature Issue or PR is a new feature

Comments

@d-gs
Copy link
Member

d-gs commented Nov 3, 2021

Feature request

Expected Behavior - What were you expecting to happen?

When the oomph project catalog is not containing an identifiable one to be assigned to a GEM project or environment, then the launcher should be disabled as it is a configuration problem, or a misconfigured-launcher should be present to show the error and communicate to the config managers to be fixed.

Current Behavior - What happens?

Currently (v 0.3.0), if the project ID is not present on the oomph project catalog the launcher fails with an exception. This is rather a configuration problem than a launch error, and should be handle properly.

Possible Solution

  1. Check the project catalog on canLaunch to disable it in case that the configuration is not present
  2. Does not provide any Eclipse launcher for an environment if it is not found on the project catalog
  3. Provide a misconfigured launcher to show to the user that Eclipse is not configured for that project

I personally prefer 2 as it is possible that an environment is not present cause that environment does not support the Eclipse launch; also the first one is possible in case that a filter for those use cases is provided (see #42).

@d-gs d-gs added Prio: Triage Triage Priority Status: Pending Issue or PR awaits response Type: Feature Issue or PR is a new feature labels Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Prio: Triage Triage Priority Status: Pending Issue or PR awaits response Type: Feature Issue or PR is a new feature
Development

No branches or pull requests

1 participant