From 8ecb866a762a0ccb9faf2f896dc9eafe5d6c7cea Mon Sep 17 00:00:00 2001
From: Idel Pivnitskiy <idel.pivnitskiy@apple.com>
Date: Thu, 12 Jan 2023 18:20:07 -0600
Subject: [PATCH] Deprecate unused `DefaultNettyConnection#initChannel(...)`
 overload (#2489)

Motivation:

#2473 added a new overload for `initChannel`, but forgot to deprecate the previous one
and update javadoc to point to the latest overload we use.
---
 .../netty/internal/DefaultNettyConnection.java        | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/servicetalk-transport-netty-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java b/servicetalk-transport-netty-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java
index 8cfc036555..749138b88d 100644
--- a/servicetalk-transport-netty-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java
+++ b/servicetalk-transport-netty-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java
@@ -371,8 +371,8 @@ private static <Read, Write> DefaultNettyConnection<Read, Write> initChildChanne
      * @param <Write> Type of objects written to the {@link NettyConnection}.
      * @return A {@link Single} that completes with a {@link DefaultNettyConnection} after the channel is activated and
      * ready to use.
-     * @deprecated Use {@code #initChannel(Channel, BufferAllocator, Executor, IoExecutor, CloseHandler, FlushStrategy,
-     * long, SslConfig, ChannelInitializer, ExecutionStrategy, Protocol, ConnectionObserver, boolean, Predicate)}.
+     * @deprecated Use {@code #initChannel(Channel, ExecutionContext, CloseHandler, FlushStrategy, long, SslConfig,
+     * ChannelInitializer, Protocol, ConnectionObserver, boolean, Predicate)}.
      */
     @Deprecated // FIXME: 0.43 - remove deprecated method
     public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChannel(
@@ -405,8 +405,8 @@ public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChan
      * @param <Write> Type of objects written to the {@link NettyConnection}.
      * @return A {@link Single} that completes with a {@link DefaultNettyConnection} after the channel is activated and
      * ready to use.
-     * @deprecated Use {@code #initChannel(Channel, BufferAllocator, Executor, IoExecutor, CloseHandler, FlushStrategy,
-     * long, SslConfig, ChannelInitializer, ExecutionStrategy, Protocol, ConnectionObserver, boolean, Predicate)}.
+     * @deprecated Use {@code #initChannel(Channel, ExecutionContext, CloseHandler, FlushStrategy, long, SslConfig,
+     * ChannelInitializer, Protocol, ConnectionObserver, boolean, Predicate)}.
      */
     @Deprecated // FIXME: 0.43 - remove deprecated method
     public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChannel(
@@ -440,7 +440,10 @@ public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChan
      * @param <Write> Type of objects written to the {@link NettyConnection}.
      * @return A {@link Single} that completes with a {@link DefaultNettyConnection} after the channel is activated and
      * ready to use.
+     * @deprecated Use {@code #initChannel(Channel, ExecutionContext, CloseHandler, FlushStrategy, long, SslConfig,
+     * ChannelInitializer, Protocol, ConnectionObserver, boolean, Predicate)}.
      */
+    @Deprecated
     public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChannel(
             Channel channel, BufferAllocator allocator, Executor executor, @Nullable IoExecutor ioExecutor,
             CloseHandler closeHandler, FlushStrategy flushStrategy, long idleTimeoutMs,