Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete machine sets created by the installer #6

Open
corvus-ch opened this issue Jul 2, 2020 · 2 comments
Open

Delete machine sets created by the installer #6

corvus-ch opened this issue Jul 2, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@corvus-ch
Copy link
Contributor

Context

The installer already creates a MachineSet per availability zone. This MachineSets need to be removed.

This can probably be solved by deploying a job object. The executed container then runs a script (or some other piece of software). The script then uses the API to identify and delete those MachineSets.

One note of warning: an IPI cluster can never have zero worker machines. Before deleting those default MachneSets, we might need to ensure, the new ones are up and running. This might not be need though as pod disruption budgets and other mechanism might prevent deletion of nodes if the workload can not be rescheduled.

Alternatives

Making all the details available, to bring those MachineSets into the cluster catalogue.

@corvus-ch corvus-ch added the enhancement New feature or request label Jul 2, 2020
@mhutter
Copy link
Member

mhutter commented Jul 28, 2022

This MachineSets need to be removed

Out of curiosity, can you elaborate why?

@corvus-ch
Copy link
Contributor Author

This issue was written in the context of GCP and a cluster set up using IPI. The generated MachineSets generate a single node pool (spread across availability zone). Our system reference architecture asks for an infra and app group. A Commodore component can not adopt/overtake resources with non-deterministic names. The solution at that time was, to have the component add the app and infra MachineSets, and have the IPI generated ones removed manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants