You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm now against the solution to #87 by #126 on no_grad, as partially reverted here.
Reason: globally disabling grad is counter-intuitive and can waste time in debugging tests to look for missing grad, especially now when we have differential functionals.
Alternative: if a model does not need grad in unit tests, we can use nn.Module.requires_grad_(False) to disable grad for this module's params.
The text was updated successfully, but these errors were encountered:
I think more than 90% of tests will not require computing gradients. So, I still think a good default setting is gradients in tests turned off. Keeping this for now as we have still to write many tests, but it might be closed.
Ref:
I'm now against the solution to #87 by #126 on no_grad, as partially reverted here.
Reason: globally disabling grad is counter-intuitive and can waste time in debugging tests to look for missing grad, especially now when we have differential functionals.
Alternative: if a model does not need grad in unit tests, we can use
nn.Module.requires_grad_(False)
to disable grad for this module's params.The text was updated successfully, but these errors were encountered: