Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stretched sidebar #28

Open
skyth3r opened this issue Jan 30, 2023 · 6 comments
Open

stretched sidebar #28

skyth3r opened this issue Jan 30, 2023 · 6 comments

Comments

@skyth3r
Copy link
Contributor

skyth3r commented Jan 30, 2023

After the latest code fix to correct #27, a new issue was introduced that caused the sidebar to stretch across the page. The sidebar width also differs between the articles page and all other pages.

I've attempted to fix this myself on my own branch here but I'm getting mixed results (I'm not good at CSS 😅 )

Here is what I see without any of my modifications after updating the theme submodule 👇
213889058-b4eb4ec5-ab20-4b5d-87a7-6fd4ce073fe1 (1)

Any chance you know how to fix this @apvarun?

@AlisaKobzar
Copy link

Bildschirmfoto 2023-02-02 um 13 39 30

I have the same issue. :(

techmagus added a commit to techmagus/hugo-theme-digital-garden that referenced this issue Feb 9, 2023
@techmagus
Copy link

Hi @skyth3r, could you try this branch: https://github.com/techmagus/hugo-theme-digital-garden/tree/27-28

I can't test it in your smartphone model, but I just realised, by reverting commit adaf612, it will reintroduce #27. It looks okay on my end, but I guess the issue is with Safari/WebKit.

For #28, what I did was to target the syntax highlighter. I added this in the head.html file:

  <style>
    div.highlight table.lntable {
      overflow-x: scroll;
      display: block;
    }
  </style>

I'm new to this theme, and I'm still grasping the inner workings of it. Originally, I was trying to find a workaround for #28 without reverting #27, while it worked, the sidebar width differs between articles (list and single) compared to the rest of the pages.

(I'll find another workaround if #27 is back.)

Anyhow, here are some screenshots:

Screenshot from 2023-02-10 07-57-15
Screenshot from 2023-02-10 07-58-07
Screenshot from 2023-02-10 07-58-31

@skyth3r
Copy link
Contributor Author

skyth3r commented Feb 15, 2023

Ooo, thanks for this @techmagus! I'll have a play around with it this weekend when I have a free moment

@skyth3r
Copy link
Contributor Author

skyth3r commented Mar 5, 2023

@techmagus just tried out your change but couldn't get it working 😅

I think for now I might just remove my code blocks from my article for now and add them back once this is fixed

elton2048 added a commit to elton2048/digital-garden-hugo-theme that referenced this issue Mar 22, 2023
@Michael-OvO
Copy link

I have the same problem here. added the HTML code but still doesn't seem to fix the side bar problem.

@methodtomymadnessdev
Copy link

I have the same issue when running npm run dev however on npm run build the sidebar issue doesn't exist. So for dev, I fixed it by changing the dev script in package.json to

npm run build:css && hugo serve -wD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants