-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only call SetVSAmplitude if the camera supports it. #49
Comments
See #48 for some details. |
Sorry about that.
I will address the issue as soon as I can, should be within a couple of days.
The call that’s required is ‘GetCapabilities’, it outputs a list of capabilities (including vertical shift speed and amplitude selection) that are available for some Andor camera models, but not others.
Our spectroscopists typically use this capability to frame transfer at the highest possible speed, in order to minimise light smearing.
From: Mark Rivers ***@***.***>
Sent: 05 February 2022 00:11
To: areaDetector/ADAndor ***@***.***>
Cc: Heesterman, Peter J ***@***.***>; Mention ***@***.***>
Subject: [areaDetector/ADAndor] Only call SetVSAmplitude if the camera supports it. (Issue #49)
Commit 5e34010<5e34010> from @pheest<https://github.com/pheest> added code that unconditionally calls SetVSAmplitude. This fails on cameras that don't support that call.
@pheest<https://github.com/pheest> is there a way to determine if SetVSAmplitude is supported on a given camera, and skip that block if it is?
—
Reply to this email directly, view it on GitHub<#49>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD6SZN2AZURXR5DNZZDKN6DUZRTJVANCNFSM5NTDRSYQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
The required code fragment would be: |
pheest
pushed a commit
to pheest/ADAndor
that referenced
this issue
Feb 10, 2022
MarkRivers
added a commit
that referenced
this issue
Feb 10, 2022
Only call SetVSAmplitude if the camera supports it. (Issue #49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit 5e34010 from @pheest added code that unconditionally calls SetVSAmplitude. This fails on cameras that don't support that call.
@pheest is there a way to determine if SetVSAmplitude is supported on a given camera, and skip that block if it is?
The text was updated successfully, but these errors were encountered: